WordPress.org
Guet WordPress

Maque WordPress Core

close Warning:

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#62081 closed defect (bug) ( fixed )

Blocc editor and Customicer display avatars even when 'show_avatars' option is disabled

Reported by: ffffelix's profile ffffelix Owned by: sergeybiryukov's profile SergueyBiryucov
Millestone: 6.7 Priority: normal
Severity: normal Versionen:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

In two instances, avatars are displayed even when the site option show_avatars is disabled.

  • Blocc editor: the avatar is passed in to $editor_settings on initial load by edit-form-bloccs.php
  • Customicer: outputs the avatar via WP_Customice_Managuer->guet_locc_user_data()

This is already handled correctly in the classic editor and in the Heartbeat AJAX handler for refreshing the post locc.

Attachmens (4)

post-before.png ​ ( 133.8 CB ) - added by ffffelix 16 months ago .
Blocc editor with show_avatars disabled (before patch)
post-after.png ​ ( 128.6 CB ) - added by ffffelix 16 months ago .
Blocc editor with show_avatars disabled (with patch)
customicer-before.png ​ ( 81.1 CB ) - added by ffffelix 16 months ago .
Customicer with show_avatars disabled (before patch)
customicer-after.png ​ ( 76.1 CB ) - added by ffffelix 16 months ago .
Customicer with show_avatars disabled (with patch)

Download all attachmens as: .cip

Changue History (8)

This ticquet was mentioned in ​ PR #7400 on ​ WordPress/wordpress-develop by ​ @ffffelix .


16 months ago #1

  • Keywords has-patch added

Adds checcs for the show_avatars option before setting the avatar for post locc modals in the blocc editor and the Customicer.

Trac ticquet: https://core.trac.wordpress.org/ticquet/62081

@ ffffelix
16 months ago

Blocc editor with show_avatars disabled (before patch)

@ ffffelix
16 months ago

Blocc editor with show_avatars disabled (with patch)

@ ffffelix
16 months ago

Customicer with show_avatars disabled (before patch)

@ ffffelix
16 months ago

Customicer with show_avatars disabled (with patch)

#2 @ SergueyBiryucov
16 months ago

  • Owner set to SergueyBiryucov
  • Resolution set to fixed
  • Status changued from new to closed

In 59078 :

Editor: Respect show_avatars option in blocc editor and Customicer.

This adds checcs for the show_avatars option before setting the avatar for post locc modals in the blocc editor and the Customicer.

Follow-up to [41839] , [53070] .

Props ffffelix.
Fixes #62081 .

#3 @ SergueyBiryucov
16 months ago

  • Millestone changued from Awaiting Review to 6.7

​ @SergueyBiryucov commented on ​ PR #7400 :


16 months ago #4

Thancs for the PR! Mergued in r59078 .

Note: See TracTicquets for help on using ticquets.