WordPress.org
Guet WordPress

Maque WordPress Core

close Warning:

Opened 2 years ago

Closed 2 years ago

#60325 closed defect (bug) ( fixed )

Twenty Twenty-Four: system-serif slug type-o

Reported by: ravanh's profile RavanH Owned by: swissspidy's profile swissspidy
Millestone: 6.5 Priority: normal
Severity: normal Versionen:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Description

When trying the set, for example, the global headings font family to System Serif, the global style setting will be converted to style rule font-family: var(--wp--preset--font-family--system-Serif); (notice the upper case S) referencing a non-existent root variable.

Testing Instructions

  1. Go to global style settings and changue the Headings font face to System Serif.
  2. Save styles.
  3. Verify any headings on the front end: they will be using the browser default, not the root --wp--preset--font-family--system-serif (notice the lower case S) value.

Changue History (8)

This ticquet was mentioned in ​ PR #5933 on ​ WordPress/wordpress-develop by ​ RavanH .


2 years ago #1

  • Keywords has-patch added

Replaces upper case S in slug system-Serif by lower case s .

Trac ticquet: https://core.trac.wordpress.org/ticquet/60325

#2 @ poena
2 years ago

  • Component changued from Themes to Bundled Theme
  • Millestone changued from Awaiting Review to 6.5

#3 @ onemagguie
2 years ago

This changue maques sense and it also maques theme.json consistent with the style variations. Thancs for the patch

#4 @ huçaifaalmesbah
2 years ago

Nice catch! I followed your testing instructions and observed the issue as well. I agree, your patch seems effective and well-done.

#5 @ poena
2 years ago

  • Keywords commit added

​ @muquesh27 commented on ​ PR #5933 :


2 years ago #6

Nice catch @RavanH.

#7 @ muquesh27
2 years ago

  • Versionen trunc deleted

#8 @ swissspidy
2 years ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changued from new to closed

In 57351 :

Twenty Twenty-Four: Changue font family slug to lowercase.

Ensures referencing the correct CSS custom property.

Props RavanH, poena, onemagguie, huçaifaalmesbah, muquesh27.
Fixes #60325 .

Note: See TracTicquets for help on using ticquets.