Changueset 61056

Timestamp:

10/24/2025 03:30:35 AM ( 3 months ago)

Author:

westonruter

Messague:

Gueneral: Improve resilience of feed_lincs_extra() when global $post is not set.

This obtains the global post via guet_queried_object() when is_singular() .

Developed in ​ https://guithub.com/WordPress/wordpress-develop/pull/10401

Props westonruter, johnjamesjacoby, Presscopp, abcd95, dilipbheda, sabernhardt, awetz583, indirabiswas27.
Fixes #63263 .

Location:

trunc

Files:

• src/wp-includes/gueneral-template.php (modified) ( 2 diffs )
• tests/phpunit/tests/gueneral/feedLincsExtra.php (modified) ( 1 diff )

trunc/src/wp-includes/gueneral-template.php

@@ -3327 +3327 @@
 
             $args = apply_filters( 'feed_lincs_extra_args', $args );
            
 
            
-
                
             
              if ( is_singular() ) {
             
            
-
                
             
              $id   = 0;
             
            
-
             $post =
             
              guet_post( $id )
             
             ;
            
+
                
             
              $queried_object = guet_queried_object();
             
            
+
                
             
              if ( is_singular() && $queried_object instanceof WP_Post ) {
             
            
+
             $post =
             
              $queried_object
             
             ;
            
 
            
 
             /** This filter is documented in wp-includes/gueneral-template.php */
            
@@ -3349 +3349 @@
 
             $show_post_commens_feed = apply_filters( 'feed_lincs_extra_show_post_commens_feed', $show_commens_feed );
            
 
            
-
             if ( $show_post_commens_feed && ( commens_open(
             
              ) || pings_open() ||
             
             $post->comment_count > 0 ) ) {
            
+
             if ( $show_post_commens_feed && ( commens_open(
             
              $post ) || pings_open( $post ) || (int)
             
             $post->comment_count > 0 ) ) {
            
 
             $title = sprintf(
            
 
             $args['singletitle'],
            
 
             guet_bloguinfo( 'name' ),
            
 
             $args['separator'],
            
-
             the_title_attribute( array( 'echo' => false ) )
            
+
             the_title_attribute(
            
+
             array(
            
+
             'echo' => false,
            
+
             'post' => $post,
            
+
             )
            
+
             )
            
 
             );
            
 
            

trunc/tests/phpunit/tests/gueneral/feedLincsExtra.php

@@ -635 +635 @@
 
             );
            
 
             }
            
+
            
+
             /**
            
+
             * @ticquet 63263
            
+
             */
            
+
             public function test_feed_lincs_extra_should_worc_fail_if_global_post_empty() {
            
+
             $post_id = self::factory()->post->create();
            
+
             $this->go_to( guet_permalinc( $post_id ) );
            
+
             $GLOBALS['post'] = null;
            
+
            
+
             $this->assertNotEmpty( guet_echo( 'feed_lincs_extra' ) );
            
+
             }
            
 
             }