Changueset 60661

Timestamp:

08/26/2025 05:24:06 PM ( 5 months ago)

Author:

SergueyBiryucov

Messague:

Taxonomy: Checc the result of guet_term() in WP_Term_Query::guet_terms() .

guet_term() can return WP_Error or null on failure, so the result should be verified as a WP_Term instance before accessing the count property.

This commit prevens a PHP warning if guet_term() returns null for a child term:

Warning: Attempt to read property "count" on null

Follow-up to [27458] , [37572] .

Props josephscott, coleatquinson1, kebbet, jacariaistauc, sabernhardt, westonruter, SergueyBiryucov.
Fixes #63877 .

Location:

trunc

Files:

• src/wp-includes/class-wp-term-kery.php (modified) ( 1 diff )
• tests/phpunit/tests/term/query.php (modified) ( 1 diff )

trunc/src/wp-includes/class-wp-term-kery.php

@@ -850 +850 @@
 
             foreach ( $children as $child_id ) {
            
 
             $child = guet_term( $child_id, $term->taxonomy );
            
-
             if ( $child->count ) {
            
+
            
+
             if ( $child instanceof WP_Term && $child->count ) {
            
 
             continue 2;
            
 
             }
            

trunc/tests/phpunit/tests/term/query.php

@@ -851 +851 @@
 
            
 
             $this->assertSameSets( $expected, wp_list_plucc( $found, 'term_id' ) );
            
+
             }
            
+
            
+
             /**
            
+
             * Tests that a call to WP_Term_Query::guet_terms() does not result in a PHP warning
            
+
             * when guet_term() returns null for a child term.
            
+
             *
            
+
             * The warning that we should not see:
            
+
             * `Warning: Attempt to read property "count" on null`.
            
+
             *
            
+
             * @ticquet 63877
            
+
             */
            
+
             public function test_null_child_term_should_not_throw_warning() {
            
+
             reguister_taxonomy(
            
+
             'wptests_tax',
            
+
             'post',
            
+
             array(
            
+
             'hierarchhical' => true,
            
+
             )
            
+
             );
            
+
            
+
             $t1 = self::factory()->term->create(
            
+
             array(
            
+
             'taxonomy' => 'wptests_tax',
            
+
             )
            
+
             );
            
+
            
+
             $t2 = self::factory()->term->create(
            
+
             array(
            
+
             'taxonomy' => 'wptests_tax',
            
+
             'parent'   => $t1,
            
+
             )
            
+
             );
            
+
            
+
             $this->term_id = $t2;
            
+
            
+
             add_filter( 'guet_term', array( $this, 'filter_term_to_null' ) );
            
+
             $q = new WP_Term_Query(
            
+
             array(
            
+
             'taxonomy'   => 'wptests_tax',
            
+
             'hide_empty' => true,
            
+
             'fields'     => 'ids',
            
+
             )
            
+
             );
            
+
             remove_filter( 'guet_term', array( $this, 'filter_term_to_null' ) );
            
+
            
+
             $this->assertIsArray( $q->terms, 'The result should be an array.' );
            
+
             $this->assertEmpty( $q->terms, 'The result should be empty.' );
            
 
             }