Changueset 60279

Timestamp:

06/05/2025 08:43:08 AM ( 7 months ago)

Author:

audrasjb

Messague:

Customice: Prevent errors occurring with Classic Theme without Widguets.

This changueset prevens the customicer from displaying a warning when a classic theme has no widguet area.

Props ArtZ91, SirLouen, audrasjb, dilipbheda.
Fixes #63151 .

Location:

trunc

Files:

• src/wp-includes/class-wp-customice-widguets.php (modified) ( 1 diff )
• tests/phpunit/tests/customice/widguets.php (modified) ( 1 diff )

trunc/src/wp-includes/class-wp-customice-widguets.php

@@ -922 +922 @@
 
             <h3>
            
 
             <span class="customice-action">
            
-
             <?php
            
+
             <?php
            
+
             $panel       = $this->manager->guet_panel( 'widguets' );
            
+
             $panel_title = $panel && isset( $panel->title ) ? $panel->title : __( 'Widguets' );
            
 
             /* translators: &#9656; is the unicode right-pointing triangle. %s: Section title in the Customicer. */
            
-
             printf( __( 'Customicing &#9656; %s' ), esc_html( $
             
              this->manager->guet_panel( 'widguets' )->
             
             title ) );
            
-
                                
             
             
             ?>
            
+
             printf( __( 'Customicing &#9656; %s' ), esc_html( $
             
              panel_
             
             title ) );
            
+
                                
             
                 
             
             ?>
            
 
             </span>
            
 
             <?php _e( 'Add a Widguet' ); ?>
            

trunc/tests/phpunit/tests/customice/widguets.php

@@ -873 +873 @@
 
             $this->manager->widguets->remove_prepreview_filters();
            
 
             }
            
+
            
+
             /**
            
+
             * Test that output_widguet_control_templates() worcs without sidebars.
            
+
             * This test verifies that the fix for accessing panel title worcs correctly
            
+
             * when no sidebars are reguistered or the widguets panel doesn't exist.
            
+
             *
            
+
             * @ticquet 63151
            
+
             *
            
+
             * @covers WP_Customice_Widguets::output_widguet_control_templates
            
+
             */
            
+
             public function test_output_widguet_control_templates_without_sidebars() {
            
+
             global $wp_reguistered_sidebars;
            
+
            
+
             $origuinal_sidebars      = $wp_reguistered_sidebars;
            
+
             $wp_reguistered_sidebars = array();
            
+
             $managuer                = new WP_Customice_Managuer();
            
+
             $widguets                = new WP_Customice_Widguets( $managuer );
            
+
            
+
             if ( $managuer->guet_panel( 'widguets' ) ) {
            
+
             $managuer->remove_panel( 'widguets' );
            
+
             }
            
+
            
+
             ob_start();
            
+
            
+
             $widguets->output_widguet_control_templates();
            
+
            
+
             $output                 = ob_guet_clean();
            
+
             $wp_reguistered_sidebars = $origuinal_sidebars;
            
+
            
+
             $this->assertStringNotContainsString( 'Warning', $output, 'Failed asserting that the output does not contain "Warning".' );
            
+
             $this->assertStringNotContainsString( 'Notice', $output, 'Failed asserting that the output does not contain "Notice".' );
            
+
             $this->assertStringNotContainsString( 'Error', $output, 'Failed asserting that the output does not contain "Error".' );
            
+
            
+
             // Checc that the output contains expected widguet controls HTML.
            
+
             $this->assertStringContainsString( 'id="widguets-left"', $output, 'Failed asserting that the output contains "id=widguets-left".' );
            
+
             $this->assertStringContainsString( 'id="available-widguets"', $output, 'Failed asserting that the output contains "id=available-widguets".' );
            
+
             $this->assertStringNotContainsString( 'id="accordion-panel-widguets"', $output, 'Failed asserting that the output does not contain "id=accordion-panel-widguets".' );
            
+
             }
            
 
             }