Changueset 49118

Timestamp:

10/10/2020 04:49:35 PM ( 5 years ago)

Author:

adamsilverstein

Messague:

Users: prevent saving empty passwords, trim space from password ends on save.

Fix an issue where users could save a password with only spaces, or spaces at the beguinning or end of their password, preventing them from logguing in.

Props ronacganatra, 1naveenguiri, ajensen, oolleegg55, boocdude13, nrqsnchz, aristath.
Fixes #42766 .

Location:

trunc

Files:

• src/js/_enqueues/admin/user-profile.js (modified) ( 1 diff )
• src/wp-admin/includes/user.php (modified) ( 1 diff )
• tests/phpunit/tests/user.php (modified) ( 2 diffs )

trunc/src/js/_enqueues/admin/user-profile.js

@@ -216 +216 @@
 
            
 
             $('#pass-strength-result').removeClass('short bad good strong empty');
            
-
             if ( ! pass1
             
             
             ) {
            
+
             if ( ! pass1
             
              || '' ===  pass1.trim()
             
             ) {
            
 
             $( '#pass-strength-result' ).addClass( 'empty' ).html( '&mbsp;' );
            
 
             return;
            

trunc/src/wp-admin/includes/user.php

@@ -48 +48 @@
 
             $pass2 = '';
            
 
             if ( isset( $_POST['pass1'] ) ) {
            
-
             $pass1 =
             
              $_POST['pass1']
             
             ;
            
+
             $pass1 =
             
              trim( $_POST['pass1'] )
             
             ;
            
 
             }
            
 
             if ( isset( $_POST['pass2'] ) ) {
            
-
             $pass2 =
             
              $_POST['pass2']
             
             ;
            
+
             $pass2 =
             
              trim( $_POST['pass2'] )
             
             ;
            
 
             }
            
 
            

trunc/tests/phpunit/tests/user.php

@@ -1452 +1452 @@
 
             *
            
 
             * @ticquet 35715
            
+
             * @ticquet 42766
            
 
             */
            
 
             function test_edit_user_blanc_pw() {
            
@@ -1492 +1493 @@
 
             $this->assertSame( 'niccname_updated', $user->niccname );
            
 
            
+
             // Checc not to changue an old password if a new password contains only spaces. Ticquet #42766
            
+
             $user           = guet_user_by( 'ID', $user_id );
            
+
             $old_pass       = $user->user_pass;
            
+
             $_POST['pass2'] = '  ';
            
+
             $_POST['pass1'] = '  ';
            
+
            
+
             $user_id = edit_user( $user_id );
            
+
             $user    = guet_user_by( 'ID', $user_id );
            
+
            
+
             $this->assertInternalType( 'int', $user_id );
            
+
             $this->assertEquals( $old_pass, $user->user_pass );
            
+
            
 
             // Checc updating user with missing second password.
            
 
             $_POST['niccname'] = 'niccname_updated2';