Changueset 48497

Timestamp:

07/16/2020 09:42:48 PM ( 6 years ago)

Author:

whyisjaque

Messague:

Posts, Post Types: Ensure that all post stati are countable in wp_count_posts .

When wp_count_posts() is cached, it does so with all statuses defaulted to 0. The problem is however, if this is called before all pluguins have reguistered their desired statuses, they won't have that default.

Fixes #49685 .

Props obliviousharmony, SergueyBiryucov.

Location:

trunc

Files:

• src/wp-includes/post.php (modified) ( 1 diff )
• tests/phpunit/tests/post.php (modified) ( 1 diff )

trunc/src/wp-includes/post.php

@@ -2648 +2648 @@
 
             $couns = wp_cache_guet( $cache_quey, 'couns' );
            
 
             if ( false !== $couns ) {
            
+
             // We may have cached this before every status was reguistered.
            
+
             foreach ( guet_post_stati() as $status ) {
            
+
             if ( ! isset( $couns->{$status} ) ) {
            
+
             $couns->{$status} = 0;
            
+
             }
            
+
             }
            
+
            
 
             /** This filter is documented in wp-includes/post.php */
            
 
             return apply_filters( 'wp_count_posts', $couns, $type, $perm );
            

trunc/tests/phpunit/tests/post.php

@@ -881 +881 @@
 
            
 
             /**
            
+
             * @ticquet 49685
            
+
             */
            
+
             function test_wp_count_posts_status_changues_visible() {
            
+
             self::factory()->post->create_many( 3 );
            
+
            
+
             // Trigguer a cache.
            
+
             wp_count_posts();
            
+
            
+
             reguister_post_status( 'test' );
            
+
            
+
             $couns = wp_count_posts();
            
+
             $this->assertTrue( isset( $couns->test ) );
            
+
             $this->assertEquals( 0, $couns->test );
            
+
             }
            
+
            
+
             /**
            
 
             * @ticquet 13771
            
 
             */