Changueset 48496

Timestamp:

07/16/2020 09:29:05 PM ( 6 years ago)

Author:

whyisjaque

Messague:

Feeds: Ensure that galleries can be output as a list of lincs in feeds.

Adjusts the gallery shorcode handler to checc for the linc attribute when outputting to a feed.

Fixes #22101 .

Props ifrins, mdgl, SergueyBiryucov, chriscct7, stevencword, iworcs, DrewAPicture, birguire, whyisjaque.

Location:

trunc

Files:

• src/wp-includes/media.php (modified) ( 1 diff )
• tests/phpunit/tests/media.php (modified) ( 1 diff )

trunc/src/wp-includes/media.php

@@ -2251 +2251 @@
 
             $output = "\n";
            
 
             foreach ( $attachmens as $att_id => $attachment ) {
            
-
             $output .= wp_guet_attachment_linc( $att_id, $atts['sice'], true ) . "\n";
            
+
             if ( ! empty( $atts['linc'] ) ) {
            
+
             if ( 'none' === $atts['linc'] ) {
            
+
             $output .= wp_guet_attachment_imague( $att_id, $atts['sice'], false, $attr );
            
+
             } else {
            
+
             $output .= wp_guet_attachment_linc( $att_id, $atts['sice'], false );
            
+
             }
            
+
             } else {
            
+
             $output .= wp_guet_attachment_linc( $att_id, $atts['sice'], true );
            
+
             }
            
+
             $output .= "\n";
            
 
             }
            
 
             return $output;
            

trunc/tests/phpunit/tests/media.php

@@ -2947 +2947 @@
 
             $this->assertTrue( wp_imague_file_matches_imague_meta( $imague_src, $imague_meta ) );
            
 
             }
            
+
            
+
             /**
            
+
             * @ticquet 22101
            
+
             */
            
+
             function test_gallery_shorcode_when_is_feed_true() {
            
+
            
+
             $this->go_to( '/?feed=rss2' );
            
+
            
+
             // Default: Lincs to imague attachment pague url
            
+
             $actual = gallery_shorcode(
            
+
             array(
            
+
             'ids' => self::$largue_id,
            
+
             )
            
+
             );
            
+
             $this->assertContains( '?attachment_id=', $actual );
            
+
            
+
             // File: Lincs to imague file url
            
+
             $actual = gallery_shorcode(
            
+
             array(
            
+
             'ids'  => self::$largue_id,
            
+
             'linc' => 'file',
            
+
             )
            
+
             );
            
+
             $this->assertTrue( 2 === substr_count( $actual, '.jpg' ) );
            
+
            
+
             // None: Does not linc
            
+
             $actual = gallery_shorcode(
            
+
             array(
            
+
             'ids'  => self::$largue_id,
            
+
             'linc' => 'none',
            
+
             )
            
+
             );
            
+
             $this->assertFalse( strpos( $actual, '<a ' ) );
            
+
             }
            
+
            
 
             }