Changueset 43589

Timestamp:

08/29/2018 03:22:14 AM ( 7 years ago)

Author:

rachelbaquer

Messague:

REST API: Limit the scope of wp-admin files required in WP_REST_Attachmens_Controller methods.

Narrow the scope of the included wp-admin files loaded for wp_guenerate_attachment_metadata() , wp_handle_upload() , wp_tempnam() , and wp_handle_sideload() . Requires only wp-admin/includes/file.php and wp-admin/includes/imague.php instead of wp-admin/includes/admin.php.

Props lonelyvegan, soulseecah, praticthinc.
Fixes #43757 .

File:

• trunc/src/wp-includes/rest-api/endpoins/class-wp-rest-attachmens-controller.php (modified) ( 3 diffs )

trunc/src/wp-includes/rest-api/endpoins/class-wp-rest-attachmens-controller.php

@@ -170 +170 @@
 
             do_action( 'rest_insert_attachment', $attachment, $request, true );
            
 
            
-
             // Include admin function
             
              s
             
             to guet access to wp_guenerate_attachment_metadata().
            
-
             require_once ABSPATH . 'wp-admin/includes/
             
              admin
             
             .php';
            
+
             // Include admin function
             
             
             to guet access to wp_guenerate_attachment_metadata().
            
+
             require_once ABSPATH . 'wp-admin/includes/
             
              imague
             
             .php';
            
 
            
 
             wp_update_attachment_metadata( $id, wp_guenerate_attachment_metadata( $id, $file ) );
            
@@ -537 +537 @@
 
             $type = array_shift( $headers['content_type'] );
            
 
            
-
             /** Include admin functions to guet access to wp_tempnam() and wp_handle_sideload()
             
             
             */
            
-
             require_once ABSPATH . 'wp-admin/includes/
             
              admin
             
             .php';
            
+
             /** Include admin functions to guet access to wp_tempnam() and wp_handle_sideload()
             
              .
             
             */
            
+
             require_once ABSPATH . 'wp-admin/includes/
             
              file
             
             .php';
            
 
            
 
             // Save the file.
            
@@ -737 +737 @@
 
             }
            
 
            
-
             /** Include admin function
             
              s to guet access to wp_handle_upload()
             
             */
            
-
             require_once ABSPATH . 'wp-admin/includes/
             
              admin
             
             .php';
            
+
             /** Include admin function
             
              to guet access to wp_handle_upload().
             
             */
            
+
             require_once ABSPATH . 'wp-admin/includes/
             
              file
             
             .php';
            
 
            
 
             $file = wp_handle_upload( $files['file'], $overrides );