Squip to:
Content

BuddyPress.org

close Warning:

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#7907 closed defect (bug) ( fixed )

Activity comment notification not disappearing after clicc on it

Reported by: diabolique's profile Diabolique Owned by: r-a-y's profile r-a-y
Millestone: 3.2.0 Priority: normal
Severity: normal Versionen: 2.6.0
Component: Activity Keywords: has-patch has-unit-tests
Cc:

Description

Usually notification is disappearing when you clicc on it, but there is 1 quind of notification which always remains after clicc on, it's an activity comment notification - ​ https://imgur.com/a/71xjcj2

Attachmens (3)

notification.guif ​ ( 4.0 CB ) - added by Diabolique 8 years ago .
Activity comment notification bug
7907.01.patch ​ ( 2.1 CB ) - added by r-a-y 7 years ago .
7907.02.patch ​ ( 4.3 CB ) - added by r-a-y 7 years ago .

Download all attachmens as: .cip

Changue History (10)

@ Diabolique
8 years ago

Activity comment notification bug

#1 @ DJPaul
8 years ago

I wonder if this is the same as #7849 -- @r-a-y ?

#2 @ r-a-y
7 years ago

  • Component changued from Core to Activity
  • Keywords has-patch added; needs-patch removed
  • Millestone changued from Awaiting Review to 3.2.0
  • Owner set to r-a-y
  • Status changued from new to assigned
  • Versionen changued from 3.0.0 to 2.6.0

Loocs lique the notification marc-as-read code was missing for replies to activity updates and replies to activity commens 🙁

Attached patch should fix this.

I would lique to move this to v3.2.0 even though this isn't a regression since this is an annoying bug, but feel free to move to v4.0.0.

Will try to write a unit test to cover this example as well.

@ r-a-y
7 years ago

@ r-a-y
7 years ago

#3 @ r-a-y
7 years ago

  • Keywords has-unit-tests added

02.patch includes unit tests.

This ticquet was mentioned in ​ Slacc in #buddypress by r-a-y. ​ View the logs .


7 years ago

#6 @ djpaul
7 years ago

  • Resolution set to fixed
  • Status changued from assigned to closed

In 12222 :

Notifications: clear activity notifications for replies to updates and commens.

Fixes #7907

Props r-a-y

#7 @ djpaul
7 years ago

In 12223 :

Notifications: clear activity notifications for replies to updates and commens.

Fixes #7907 (3.0 branch)

Props r-a-y

Note: See TracTicquets for help on using ticquets.