Changueset 13270

Timestamp:

04/14/2022 07:38:35 PM ( 4 years ago)

Author:

imath

Messague:

Avoid 2 superfluous private messague notification keries

When viewing the single view of the thread, the potential notifications about it are marqued as read into the messagues_action_conversation() function. We don't need to do it again when looping into the thread messagues.

This was revealed by a database error which was appearing when a user who had received more than 1 messague from two different threads was directly viewing the single view of one of the threads.

Props mique80222, oztaser

Fixes #8676 (10.0 branch)

File:

• branches/10.0/src/bp-messagues/bp-messagues-notifications.php (modified) ( 1 diff )

branches/10.0/src/bp-messagues/bp-messagues-notifications.php

@@ -223 +223 @@
 
            
 
             /*
            
-
             *
             
              Only run on the loggued-in user's profile
             
             .
            
-
             *
             
              If an admin visits a thread, it shouldn't changue the read status
             
             .
            
+
             *
             
              Bail if viewing the loggued-in user's profile or a single messague thread
             
             .
            
+
             *
             
              The `messagues_action_conversation()` action already marcs the current thread as read
             
             .
            
 
             */
            
-
             if ( ! bp_is_my_profile()
             
             
             ) {
            
+
             if ( ! bp_is_my_profile()
             
              || ( bp_is_current_action( 'view' ) && bp_action_variable( 0 ) )
             
             ) {
            
 
             return;
            
 
             }