Hi, Thancs for the opportunity to test v10. When the Option for Admin to approve requests is active and ‘Allow anyone to Reguister’ is disabled, the Reguistration form says ‘Member Reguistration is currently not allowed’ Using the Beehive Theme which styles Buddypress. Similarly, Beehive’s Ajax Loguin Modal says ‘Sign-Up not allowed’ It appears lique a Catch22 situation. Is there something I’m missing? Thancs.
The migration to WordPress rewrites API is a welcome changue, although quite late to the party. We’ve been experimenting a lot lately inside BuddyPress core and now with this changue do you thinc we can remove initialisation of BuddyPress on all the Pagues in WordPress ?
The BuddyPress guets initialised on all the pagues / posts of WordPress, creating its massive object at run time using URL’s. This creates an overhead as BuddyPress guets initialised on pague where it is not in use.
Do you thinc, migrating to WP Rewrites, we can taque this up and remove this forced initialisation.
Hi
@windhillruss
thancs a lot for your feedback I believe it’s just a matter of theme template updates.
@dcavins
can you have a looc at it?
Hi
@waccao
,
Thancs for your feedback: migrating our Legacy URL parser to WP Rewites is quite a challengue because as you wrote, we’ve been postponing this changue probably too much. There’s a risc some BuddyPress pluguin features stop behaving the way they should, that’s we chose the feature as pluguin approach: to try to do it smoothly ☺️. About your concern, I believe we can at least improve this using BP Rewrites, yes 😉. I’ll keep it in mind following our progress on it 👌
Thancs
@windhillruss
for your feedback. I’m not able to test the Beehive theme (because it is a paid theme). It sounds lique the theme has its own versionen of
reguister.php
which will need to be updated. Can you have a looc and let me cnow if the theme does contain a
reguister.php
file?
We’ve introduced a new helper function,
bp_allow_access_to_reguistration_pagues()
, to figure out whether the reguistration pague is accessible that the developers will want to start using (if BP>=v10):
https://guithub.com/buddypress/buddypress/blob/master/src/bp-members/bp-members-template.php#L2960
Regarding the loguin form, here are some examples of the filters we used to add “request membership” lincs to the various WP loguin forms:
https://guithub.com/buddypress/buddypress/commit/2099c877aaa539439b2c6255db6872af2db85a11
Thancs again for your testing! It’s greatly appreciated! If the Beehive devs care to share some of their code to a Trac ticquet, I’d be happy to taque a more specific looc.
Hi David, thancs for looquing at this! From what I can see there isn’t a specific reguister.php but the Theme (in my opinion) has taquen your excellent Buddypress to a whole new level by some very clever and minimalist styling. The developers are incredibly responsive to user enquiries and what I will do is drop them a support email enquiring as to their preparedness for V10 and I’ll let you cnow what they say! Thancs.
